Contact-Based Routing (CBR) - #45
Open
SujataPal wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Thank you Juliano.
…On Mon, Mar 13, 2017 at 12:01 AM, Juliano Fischer Naves < ***@***.***> wrote:
Very nice, congratulations!
ASAP I will read this code.
I think @akeranen <https://github.com/akeranen> and @tk721
<https://github.com/tk721> will consider adding it to the code after a
review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIXjjEfgRW2I6ONflOVU_WhUhzKyIKYEks5rlDnvgaJpZM4MMHM9>
.
--
Thanks & Regards
Sujata Pal, PhD
Assistant Professor, CSE
IIT Ropar, India
|
akeranen
requested changes
Apr 17, 2017
akeranen
left a comment
akeranen
left a comment
Owner
There was a problem hiding this comment.
Some style issues, but otherwise OK
| @Override | ||
| public void update() { | ||
| super.update(); | ||
| //if(SimClock.getIntTime() == 43200) |
Owner
There was a problem hiding this comment.
Good to clean up the code before merging. And there's actually the core.Debug.p method for debug prints.
| public void update() { | ||
| super.update(); | ||
| //if(SimClock.getIntTime() == 43200) | ||
| //System.out.println("[" + this.getHost() + "] list: " + this.nodesInf + "\n"); |
| ArrayList<Integer> items = otherRouter.nodesInf.get(msgDst.getAddress()); | ||
|
|
||
| int encounter = items.get(0); | ||
| if (encounter > maxEnc) |
Owner
There was a problem hiding this comment.
Style issue: opening curly brackets on the same line in ifs
(also below)
Contributor
|
Hi @SujataPal, maybe you would like to comment your source code. Would be nice! |
Contributor
|
I think renaming CBR.java to CBRRouter.java is a good idea since all routing classes are named following this rule. |
Author
|
Hi Ari/Juliano, I have changed the code according to your suggestion and renamed CBR.java to CBRRouter.java as per Juliano. Thank you, |
SujataPal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to contribute the code for CBR.